[GitHub] [arrow-datafusion] houqp commented on a change in pull request #1294: improve error message for invalid create table statement

[GitBox]

houqp commented on a change in pull request #1294:
URL: https://github.com/apache/arrow-datafusion/pull/1294#discussion_r748950117



##########
File path: datafusion/src/sql/planner.rs
##########
@@ -150,17 +150,24 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
                 external: false,
                 if_not_exists: false,
                 without_rowid: _without_row_id,
-            } if columns.is_empty()
-                && constraints.is_empty()
-                && table_properties.is_empty()
-                && with_options.is_empty() =>
-            {
-                let plan = self.query_to_plan(query)?;
+            } => {
+                if columns.is_empty()

Review comment:
       Good call, I have pushed a new commit to address this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org