jonkeane commented on a change in pull request #11644:
URL: https://github.com/apache/arrow/pull/11644#discussion_r749710583
##########
File path: dev/tasks/r/github.devdocs.yml
##########
@@ -59,10 +61,22 @@ jobs:
env:
LIBARROW_BINARY: FALSE
ARROW_R_DEV: TRUE
- run: bash arrow/r/vignettes/script.sh
+ DEVDOCS_WINDOWS: {{ "${{contains(matrix.os, 'windows')}}" }}
+ run: |
+ if [ $DEVDOCS_WINDOWS == "true" ]; then
+ # This starts a special mingw64 Git Bash shell
+ $RTOOLS40_HOME/msys2_shell.cmd -here -mingw64 -no-start -defterm
-full-path arrow/r/vignettes/script.sh
+ else
+ bash arrow/r/vignettes/script.sh
+ fi
shell: bash
- name: Ensure that the Arrow package is loadable and we have the
correct one
+ env:
+ DEVDOCS_WINDOWS: {{ "${{contains(matrix.os, 'windows')}}" }}
run: |
+ if [ $DEVDOCS_WINDOWS == "true" ]; then
+ export PATH=/c/R/bin:$PATH
+ fi
Review comment:
Does
https://github.com/apache/arrow/pull/11644/files#diff-2b2d49671e5793afb57b091dffc4722fe093ef5f627f74dda35275f1450f897dR45
below do this same thing when installing? It might be nice to add a comment
here that explains that.
Or better yet, add it to the bashprofile too? like you do at
https://github.com/apache/arrow/pull/11644/files#diff-2b2d49671e5793afb57b091dffc4722fe093ef5f627f74dda35275f1450f897dR192
##########
File path: r/vignettes/developing.Rmd
##########
@@ -38,6 +39,14 @@ set -e
set -x
```
+
+```{bash, save=run & windows, hide=TRUE}
+# Part of Path, including the path to R's bin, needs to be fixed.
+export PATH=$(cygpath --path $PATH)
+# For some reason CRAN Mirror goes missing in CI
+echo 'options(repos=structure(c(CRAN="https://cloud.r-project.org";)))' >
$HOME/.Rprofile
Review comment:
That's odd! What happens when this line isn't here? Do you have a link
to a build where that was an issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
