houqp commented on issue #1228: URL: https://github.com/apache/arrow-datafusion/issues/1228#issuecomment-969904067
Thanks @xudong963 for the detailed write up. > Enum variants are not types, so LogicalPlan::TableScan can't be a function parameter or stored, you need to pass Logical Plan. But if each enum variant has its own type, TableScan can be passed and stored. This to me is my favorite benefit :+1: This effectively means if a series of function calls needs access to a particular plan node, we only need to match on LogicalPlan once, resulting in more readable and performant code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
