alamb commented on a change in pull request #1325:
URL: https://github.com/apache/arrow-datafusion/pull/1325#discussion_r753477141



##########
File path: datafusion/src/optimizer/constant_folding.rs
##########
@@ -107,7 +107,7 @@ impl OptimizerRule for ConstantFolding {
 
                 utils::from_plan(plan, &expr, &new_inputs)
             }
-            LogicalPlan::TableScan { .. } | LogicalPlan::EmptyRelation { .. } 
=> {
+            LogicalPlan::TableScan { .. } | LogicalPlan::EmptyRelation(_) => {

Review comment:
       perhaps we can do this in a follow on pr. Good spot @xudong963 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to