kou commented on a change in pull request #10260:
URL: https://github.com/apache/arrow/pull/10260#discussion_r753515902
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -3661,17 +3711,7 @@ macro(build_google_cloud_cpp_storage)
add_dependencies(google_cloud_cpp_dependencies nlohmann_json_ep)
# Typically the steps to build the AWKSSDK provide `CURL::libcurl`, but if
that is
# disabled we need to provide our own.
- if(NOT TARGET CURL::libcurl)
- find_package(CURL REQUIRED)
- if(NOT TARGET CURL::libcurl)
- # For CMake 3.11 or older
- add_library(CURL::libcurl UNKNOWN IMPORTED)
- set_target_properties(CURL::libcurl
- PROPERTIES INTERFACE_INCLUDE_DIRECTORIES
- "${CURL_INCLUDE_DIRS}" IMPORTED_LOCATION
-
"${CURL_LIBRARIES}")
- endif()
- endif()
+ find_curl()
Review comment:
Can we remove this `find_curl()` and the above `Typically ...` comment
for cURL?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
