thisisnic commented on a change in pull request #11758:
URL: https://github.com/apache/arrow/pull/11758#discussion_r754533340
##########
File path: r/R/type.R
##########
@@ -360,6 +363,12 @@ decimal <- function(precision, scale) {
} else {
stop('"precision" must be an integer', call. = FALSE)
}
+ if (precision > 38) {
+ stop('"precision" must be lower than or equal to 38', call. = FALSE)
+ }
+ if (precision < 1) {
+ stop('"precision" must be greater than 0', call. = FALSE)
+ }
Review comment:
I know we use `assert_that()` in a lot of the rest of the code - any
reason to not use that here? Asking only out of curiosity as I think it looks
better this way anyway. Feel free to ignore this picky question!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
