jonkeane commented on a change in pull request #11521:
URL: https://github.com/apache/arrow/pull/11521#discussion_r754670069



##########
File path: r/vignettes/install.Rmd
##########
@@ -392,7 +418,6 @@ Some features are optional when you build Arrow from 
source. With the exception
 * `ARROW_JSON` for the JSON parsing library
 * `ARROW_WITH_RE2` for the RE2 regular expression library, used in some string 
compute functions
 * `ARROW_WITH_UTF8PROC` for the UTF8Proc string library, used in many other 
string compute functions
-* `ARROW_JSON` for JSON parsing

Review comment:
       Any reason for removing this? 

##########
File path: r/vignettes/install.Rmd
##########
@@ -41,13 +41,17 @@ release of the R package along with any C++ dependencies.
 
 # Installation basics
 
+## Install the latest release
+

Review comment:
       I think we should explain that `NOT_CRAN` is our catch all that will 
enable all of the nicities we can't/don't want to expose on CRAN (currently 
that's binaries + more features, but I could imagine more in the future).
   
   I would advocate for explaining this slightly lower (right below the code 
here for example) to give folks interested a place to look for it, but for 
people who don't care why they can just copy/paste without needing that 
exposition 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to