jonkeane commented on a change in pull request #11678:
URL: https://github.com/apache/arrow/pull/11678#discussion_r754681636
##########
File path: r/vignettes/developers/docker.Rmd
##########
@@ -0,0 +1,71 @@
+# Using docker with Arrow
+
+Arrow is compatible with a huge number of combinations of OSs, OS versions,
+compilers, R versions, and other variables. Sometimes these combinations of
+variables means that behaviours are found in some environments which cannot be
+replicated in others. In addition, there are different ways of building
Arrow,
+for example, using environment variables to specify the building of optional
+components.
Review comment:
```suggestion
for example, enabling the building of optional components.
```
Not sure we need to mention env vars here
##########
File path: r/vignettes/developers/docker.Rmd
##########
@@ -0,0 +1,71 @@
+# Using docker with Arrow
+
+Arrow is compatible with a huge number of combinations of OSs, OS versions,
+compilers, R versions, and other variables. Sometimes these combinations of
Review comment:
> a huge number of combinations of OSs, OS versions, compilers, R
versions, and other variable
I feel like this is one of those lines that might be prefaced with
"~unfortunately~ fortunately, ... " 😂 (not actually suggesting to add this,
just commenting on the vibe)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
