Jimexist commented on pull request #888: URL: https://github.com/apache/arrow-rs/pull/888#issuecomment-976033139
> Looks pretty cool to me -- thanks @Jimexist > > One major questions for other reviewers: Are we ok with adding a new dependency (on `half`?) -- in the IOx project, it turns out we already have `half` because `serde_cbor` depends on it, because `criterion depends on it` 🤷 > > I think some basic tests are in order -- perhaps a doctest showing how to construct an `F16Array` perhaps? do you mean this: https://github.com/apache/arrow-rs/pull/888/files#diff-dd779d74625591eb0e2a5648a76db5b714f4135ee094afd77e87a584f9f264fbR199? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
