emkornfield commented on a change in pull request #11709:
URL: https://github.com/apache/arrow/pull/11709#discussion_r755689720
##########
File path:
java/vector/src/main/java/org/apache/arrow/vector/BitVectorHelper.java
##########
@@ -329,7 +329,8 @@ public static ArrowBuf loadValidityBuffer(final
ArrowFieldNode fieldNode,
final int valueCount = fieldNode.getLength();
ArrowBuf newBuffer = null;
/* either all NULLs or all non-NULLs */
- if (fieldNode.getNullCount() == 0 || fieldNode.getNullCount() ==
valueCount) {
+ if (sourceValidityBuffer == null && (fieldNode.getNullCount() == 0 ||
Review comment:
sorry to be clearer. The spec only allows for the bitmap to be null if
all values are present, not if all values are null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
