save-buffer commented on a change in pull request #11579:
URL: https://github.com/apache/arrow/pull/11579#discussion_r756376365
##########
File path: cpp/src/arrow/compute/exec/hash_join_node_test.cc
##########
@@ -382,19 +382,24 @@ struct RandomDataTypeVector {
data_types.push_back(RandomDataType::Random(rng, constraints));
}
+ std::string DataTypeToString(size_t i) {
+ std::stringstream ss;
+
+ if (!data_types[i].is_fixed_length) {
+ ss << "str[" << data_types[i].min_string_length << ".."
+ << data_types[i].max_string_length << "]";
+ } else {
+ ss << "int[" << data_types[i].fixed_length << "]";
+ }
+ return ss.str();
+ }
+
void Print() {
Review comment:
Ah yeah seems that there was a print before that used these but then
after rebasing those prints got deleted. I'll just remove these functions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
