alamb commented on pull request #975:
URL: https://github.com/apache/arrow-rs/pull/975#issuecomment-982023802
Hi @matthewmturner
> locally i get an unused warning on std::fmt::Write but if i remove it i
get error when using write! macro.
I think that is due to the fact that the `Write` is only used in tests.
So if you change the code with something like
```diff
diff --git a/arrow/src/util/pretty.rs b/arrow/src/util/pretty.rs
index 144eb6b601..e0f3574ed2 100644
--- a/arrow/src/util/pretty.rs
+++ b/arrow/src/util/pretty.rs
@@ -19,7 +19,7 @@
//! available unless `feature = "prettyprint"` is enabled.
use crate::{array::ArrayRef, record_batch::RecordBatch};
-use std::fmt::{Display, Write};
+use std::fmt::Display;
use comfy_table::{Cell, Table};
@@ -120,6 +120,7 @@ mod tests {
use super::*;
use crate::array::{DecimalBuilder, Int32Array};
use std::sync::Arc;
+ use std::fmt::Write;
#[test]
fn test_pretty_format_batches() -> Result<()> {
```
I pushed a fix to your branch and resolved a conflict (I caused)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
