[GitHub] [arrow] save-buffer commented on a change in pull request #11789: ARROW-14898: [C++][Compute] Fix crash of out-of-bounds memory accessing in key_hash if a key is smaller than int64

[GitBox]

save-buffer commented on a change in pull request #11789:
URL: https://github.com/apache/arrow/pull/11789#discussion_r759503470



##########
File path: cpp/src/arrow/compute/exec/key_compare.cc
##########
@@ -276,8 +276,9 @@ void KeyCompare::CompareVarBinaryColumnToRow(
         uint64_t key_right = key_right_ptr[j];
         result_or |= key_left ^ key_right;
       }
-      uint64_t tail_mask = ~0ULL >> (64 - 8 * (length - j * 8));
-      uint64_t key_left = util::SafeLoad(key_left_ptr + j);
+      int32_t tail_length = length - j * 8;
+      uint64_t tail_mask = ~0ULL >> (64 - 8 * (tail_length));

Review comment:
       Well I'm referring to the parents around tail_length, where there are no 
operators inside. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org