pitrou commented on a change in pull request #11836:
URL: https://github.com/apache/arrow/pull/11836#discussion_r761305684
##########
File path: cpp/src/arrow/csv/writer.cc
##########
@@ -289,11 +306,23 @@ class CSVWriterImpl : public ipc::RecordBatchWriter {
io::OutputStream* sink, std::shared_ptr<io::OutputStream> owned_sink,
std::shared_ptr<Schema> schema, const WriteOptions& options) {
RETURN_NOT_OK(options.Validate());
+ // Reject null string values that contain quotes.
+ if (CountEscapes(options.null_string) != 0) {
+ return Status::Invalid("CSV null value string cannot contain quotes.",
+ options.null_string);
Review comment:
This will result in a formatted message such as `CSV null value string
cannot contain quotes.ab"c`, perhaps arrange it a bit better? Or we can simply
omit the actual `null_string` value since it is a user-defined parameter anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
