ianmcook commented on a change in pull request #11833:
URL: https://github.com/apache/arrow/pull/11833#discussion_r761513977
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -463,7 +463,6 @@ if(DEFINED ENV{ARROW_GBENCHMARK_URL})
else()
set_urls(GBENCHMARK_SOURCE_URL
"https://github.com/google/benchmark/archive/${ARROW_GBENCHMARK_BUILD_VERSION}.tar.gz";
-
"https://github.com/ursa-labs/thirdparty/releases/download/latest/gbenchmark-${ARROW_GBENCHMARK_BUILD_VERSION}.tar.gz";
Review comment:
@kou 💯 agreed, we should move all the bundled third-party dependencies
mirror to an ASF-managed repository such as JFrog. @bkmgit has been pushing for
this recently and I think there is broad support for it. This is being tracked
in ARROW-6407 and I think it would be most constructive to handle it as a
consolidated effort, not do it as one-offs for each dependency.
Is it OK with you if we keep the Ursa thirdparty repo in here for now, and
discuss this move to JFrog in ARROW-6407? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
