carols10cents opened a new pull request #1001: URL: https://github.com/apache/arrow-rs/pull/1001
# Which issue does this PR close? Connects to #770. I'm not sure if this PR completely fixes it or not 😅 # Rationale for this change The parquet benchmarks use some types that are behind the test_common feature. The benchmarks don't build without turning on that feature. CI doesn't currently check that benches build, nor is this feature requirement documented anywhere. # What changes are included in this PR? The first commit adds a job to CI to build (but not run) all benches in the workspace. I pushed this commit up first to demonstrate that it's currently failing. The second commit adds `--features test_common` to the CI job, and it now passes. I've also documented the need for this flag in parquet/CONTRIBUTING.md. Ideally, it'd be nice to be able to turn on a feature in Cargo.toml `[bench]` targets, but afaik that isn't possible currently. Another possible solution is removing the `cfg` from these types, but I wasn't sure if that was desired or not. # Are there any user-facing changes? Users trying to build parquet's benchmarks should be able to if they read the docs or check what CI does :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
