alamb commented on a change in pull request #1402:
URL: https://github.com/apache/arrow-datafusion/pull/1402#discussion_r763928259
##########
File path: datafusion/src/logical_plan/plan.rs
##########
@@ -38,7 +38,7 @@ pub enum JoinType {
Inner,
/// Left Join
Left,
- /// Right Join
+ /// Right Join: will be transferred to Left Join
Review comment:
Yes I think you are right that if we removed the `Right` variant then we
would have to add some other way to encode the "which to hash"
I find the standard terminology confusing because there is an (implicit)
optimization for one of the two join inputs in most implementations (e.g. hash
join, which one to hash) that is often encoded as "which appears as the left
argument in the tree" which has a different meaning than a `LEFT JOIN`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
