edponce commented on a change in pull request #11886:
URL: https://github.com/apache/arrow/pull/11886#discussion_r764326150
##########
File path: cpp/src/arrow/compute/kernels/scalar_validity.cc
##########
@@ -189,6 +191,72 @@ Status ConstBoolExec(KernelContext* ctx, const ExecBatch&
batch, Datum* out) {
return Status::OK();
}
+struct NonZeroVisitor {
+ UInt32Builder *builder;
Review comment:
AFAIK, indices in Arrow are usually represented with `int64_t`. Also, it
might be the case that a different integer type is desired, so can these be
generalized? Maybe using `NumericBuilder<...>` but these would not allow using
`BooleanBuilder`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
