cyb70289 commented on a change in pull request #11896:
URL: https://github.com/apache/arrow/pull/11896#discussion_r764854640



##########
File path: cpp/src/arrow/csv/parser.cc
##########
@@ -184,6 +184,31 @@ class SSE42Filter {
   const BulkFilterType filter_;
 };
 
+#elif defined ARROW_HAVE_NEON
+
+// NEON filter: 8 bytes at a time, comparing with all special chars
+
+class NeonFilter {

Review comment:
       The code is using legacy 64 bit SIMD registers (uint8x8_t, __m64), xsimd 
doesn't support them.
   As WordType is 64 bits, using 128 bit register here is inconvenient and 
hurts performance per my test.
   I didn't try changing WordType to 128 bits, guess it may influence other 
tests.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to