tustvold opened a new pull request #1031:
URL: https://github.com/apache/arrow-rs/pull/1031
# Which issue does this PR close?
Relates to #171
# Rationale for this change
The logic for driving a `RecordReader` from a `PageIterator` is currently
duplicated in `PrimitiveArrayReader` and `NullArrayReader`. This duplication
will only increase with new `ArrayReader` implementations added as part of #171
# What changes are included in this PR?
Extracts a read_records function to handle this logic
# Are there any user-facing changes?
This no longer eagerly populates the `RecordReader` with the first
`PageReader` from the `PageIterator`. If for example the first page of the
first row group contained a compression codec that was not supported, this
would currently error in the constructor, whereas with this change it will
error in `ArrayReader::next_batch`. I personally think this makes more sense.
FWIW I think this is the only possible error case and so it is unlikely
user-code would be impacted...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
