tustvold commented on a change in pull request #1041:
URL: https://github.com/apache/arrow-rs/pull/1041#discussion_r767696543
##########
File path: parquet/src/arrow/record_reader.rs
##########
@@ -16,75 +16,248 @@
// under the License.
use std::cmp::{max, min};
-use std::mem::{replace, size_of};
-
-use crate::column::{page::PageReader, reader::ColumnReaderImpl};
+use std::marker::PhantomData;
+use std::mem::replace;
+use std::ops::Range;
+
+use crate::arrow::record_reader::private::{
+ DefinitionLevels, RecordBuffer, RepetitionLevels,
+};
+use crate::column::{
+ page::PageReader,
+ reader::{
+ private::{
+ ColumnLevelDecoder, ColumnLevelDecoderImpl, ColumnValueDecoder,
+ ColumnValueDecoderImpl,
+ },
+ GenericColumnReader,
+ },
+};
use crate::data_type::DataType;
-use crate::errors::{ParquetError, Result};
+use crate::errors::Result;
use crate::schema::types::ColumnDescPtr;
use arrow::array::BooleanBufferBuilder;
use arrow::bitmap::Bitmap;
use arrow::buffer::{Buffer, MutableBuffer};
+pub(crate) mod private {
Review comment:
This is effectively my workaround for #1032 - these traits and
accompanying types should not be part of the public API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
