edponce commented on a change in pull request #11937: URL: https://github.com/apache/arrow/pull/11937#discussion_r770940279
########## File path: cpp/src/arrow/compute/kernels/vector_is_monotonic.cc ########## @@ -0,0 +1,321 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "arrow/compute/api_vector.h" +#include "arrow/compute/kernel.h" +#include "arrow/compute/kernels/aggregate_internal.h" +#include "arrow/compute/registry.h" +#include "arrow/util/optional.h" + +namespace arrow { +namespace compute { +namespace internal { + +namespace { +// ---------------------------------------------------------------------- +// IsMonotonic implementation + +using IsMonotonicState = OptionsWrapper<IsMonotonicOptions>; + +Status IsMonotonicOutput(bool increasing, bool strictly_increasing, bool decreasing, + bool strictly_decreasing, Datum* out) { + ARROW_ASSIGN_OR_RAISE( + *out, StructScalar::Make({std::make_shared<BooleanScalar>(increasing), + std::make_shared<BooleanScalar>(strictly_increasing), + std::make_shared<BooleanScalar>(decreasing), + std::make_shared<BooleanScalar>(strictly_decreasing)}, + {"increasing", "strictly_increasing", "decreasing", + "strictly_decreasing"})); + return Status::OK(); +} + +template <typename DataType> +enable_if_floating_point<DataType> IsMonotonicCheck( + const typename DataType::c_type& current, const typename DataType::c_type& next, + bool* increasing, bool* strictly_increasing, bool* decreasing, + bool* strictly_decreasing, const IsMonotonicOptions& options) { + // Short circuit for NaNs. + // https://en.wikipedia.org/wiki/NaN#Comparison_with_NaN + if (std::isnan(current) || std::isnan(next)) { + *increasing = false; + *strictly_increasing = false; + *decreasing = false; + *strictly_decreasing = false; + } else { + bool equal = + // Approximately equal within some error bound (epsilon). + (options.floating_approximate && + (fabs(current - next) <= + static_cast<typename DataType::c_type>(options.epsilon))) || + // Or exactly equal. + current == next; + if (*increasing) { + if (!(equal || next > current)) { + *increasing = false; + *strictly_increasing = false; + } + } + if (*decreasing) { + if (!(equal || next < current)) { + *decreasing = false; + *strictly_decreasing = false; + } + } + if (*strictly_increasing) { + if (equal || !(next > current)) { + *strictly_increasing = false; + } + } + if (*strictly_decreasing) { + if (equal || !(next < current)) { + *strictly_decreasing = false; + } + } + } +} + +template <typename DataType> +enable_if_not_floating_point<DataType> IsMonotonicCheck( + const typename DataType::c_type& current, const typename DataType::c_type& next, + bool* increasing, bool* strictly_increasing, bool* decreasing, + bool* strictly_decreasing, const IsMonotonicOptions& options) { + if (*increasing) { + if (!(next >= current)) { + *increasing = false; + *strictly_increasing = false; + } + } + if (*strictly_increasing) { + if (!(next > current)) { + *strictly_increasing = false; + } + } + if (*decreasing) { + if (!(next <= current)) { + *decreasing = false; + *strictly_decreasing = false; + } + } + if (*strictly_decreasing) { + if (!(next < current)) { + *strictly_decreasing = false; + } + } +} + +template <typename DataType> +enable_if_floating_point<DataType, bool> isnan( + const util::optional<typename DataType::c_type>& opt) { + return opt.has_value() && std::isnan(opt.value()); +} + +template <typename DataType> +enable_if_not_floating_point<DataType, bool> isnan( + const util::optional<typename DataType::c_type>& opt) { + return false; Review comment: Ideally, `isnan()` should only be used in floating-point-enabled functions, so maybe you can function overload (using enable-if) the code blocks that use `isnan()` too generically. ########## File path: cpp/src/arrow/compute/kernels/vector_is_monotonic.cc ########## @@ -0,0 +1,321 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "arrow/compute/api_vector.h" +#include "arrow/compute/kernel.h" +#include "arrow/compute/kernels/aggregate_internal.h" +#include "arrow/compute/registry.h" +#include "arrow/util/optional.h" + +namespace arrow { +namespace compute { +namespace internal { + +namespace { +// ---------------------------------------------------------------------- +// IsMonotonic implementation + +using IsMonotonicState = OptionsWrapper<IsMonotonicOptions>; + +Status IsMonotonicOutput(bool increasing, bool strictly_increasing, bool decreasing, + bool strictly_decreasing, Datum* out) { + ARROW_ASSIGN_OR_RAISE( + *out, StructScalar::Make({std::make_shared<BooleanScalar>(increasing), + std::make_shared<BooleanScalar>(strictly_increasing), + std::make_shared<BooleanScalar>(decreasing), + std::make_shared<BooleanScalar>(strictly_decreasing)}, + {"increasing", "strictly_increasing", "decreasing", + "strictly_decreasing"})); + return Status::OK(); +} + +template <typename DataType> +enable_if_floating_point<DataType> IsMonotonicCheck( + const typename DataType::c_type& current, const typename DataType::c_type& next, + bool* increasing, bool* strictly_increasing, bool* decreasing, + bool* strictly_decreasing, const IsMonotonicOptions& options) { + // Short circuit for NaNs. + // https://en.wikipedia.org/wiki/NaN#Comparison_with_NaN + if (std::isnan(current) || std::isnan(next)) { + *increasing = false; + *strictly_increasing = false; + *decreasing = false; + *strictly_decreasing = false; + } else { + bool equal = + // Approximately equal within some error bound (epsilon). + (options.floating_approximate && + (fabs(current - next) <= + static_cast<typename DataType::c_type>(options.epsilon))) || + // Or exactly equal. + current == next; + if (*increasing) { + if (!(equal || next > current)) { + *increasing = false; + *strictly_increasing = false; + } + } + if (*decreasing) { + if (!(equal || next < current)) { + *decreasing = false; + *strictly_decreasing = false; + } + } + if (*strictly_increasing) { + if (equal || !(next > current)) { + *strictly_increasing = false; + } + } + if (*strictly_decreasing) { + if (equal || !(next < current)) { + *strictly_decreasing = false; + } + } + } +} + +template <typename DataType> +enable_if_not_floating_point<DataType> IsMonotonicCheck( + const typename DataType::c_type& current, const typename DataType::c_type& next, + bool* increasing, bool* strictly_increasing, bool* decreasing, + bool* strictly_decreasing, const IsMonotonicOptions& options) { + if (*increasing) { + if (!(next >= current)) { + *increasing = false; + *strictly_increasing = false; + } + } + if (*strictly_increasing) { + if (!(next > current)) { + *strictly_increasing = false; + } + } + if (*decreasing) { + if (!(next <= current)) { + *decreasing = false; + *strictly_decreasing = false; + } + } + if (*strictly_decreasing) { + if (!(next < current)) { + *strictly_decreasing = false; + } + } +} + +template <typename DataType> +enable_if_floating_point<DataType, bool> isnan( + const util::optional<typename DataType::c_type>& opt) { + return opt.has_value() && std::isnan(opt.value()); +} + +template <typename DataType> +enable_if_not_floating_point<DataType, bool> isnan( + const util::optional<typename DataType::c_type>& opt) { + return false; +} + +template <typename DataType> +constexpr enable_if_floating_point<DataType, typename DataType::c_type> min() { + return -std::numeric_limits<typename DataType::c_type>::infinity(); +} + +template <typename DataType> +constexpr enable_if_floating_point<DataType, typename DataType::c_type> max() { + return std::numeric_limits<typename DataType::c_type>::infinity(); +} + +template <typename DataType> +constexpr enable_if_not_floating_point<DataType, typename DataType::c_type> min() { + return std::numeric_limits<typename DataType::c_type>::min(); +} + +template <typename DataType> +constexpr enable_if_not_floating_point<DataType, typename DataType::c_type> max() { + return std::numeric_limits<typename DataType::c_type>::max(); +} + +template <typename DataType> +Status IsMonotonic(KernelContext* ctx, const ExecBatch& batch, Datum* out) { + using ArrayType = typename TypeTraits<DataType>::ArrayType; + using CType = typename TypeTraits<DataType>::CType; + + auto options = IsMonotonicState::Get(ctx); + + // Check batch size + if (batch.values.size() != 1) { Review comment: AFAIK, the number of arguments to a function are validated in the compute layer mechanism. When the [`IsMonotonic` function is registered, it specifies a single input argument](https://github.com/apache/arrow/pull/11937/files#diff-011285d7622074d16c9075007d23066a4fbb31fd9bb95c596dab315ed0ca038aR273), so this should be already guaranteed. ########## File path: cpp/src/arrow/compute/kernels/vector_is_monotonic.cc ########## @@ -0,0 +1,321 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "arrow/compute/api_vector.h" +#include "arrow/compute/kernel.h" +#include "arrow/compute/kernels/aggregate_internal.h" +#include "arrow/compute/registry.h" +#include "arrow/util/optional.h" + +namespace arrow { +namespace compute { +namespace internal { + +namespace { +// ---------------------------------------------------------------------- +// IsMonotonic implementation + +using IsMonotonicState = OptionsWrapper<IsMonotonicOptions>; + +Status IsMonotonicOutput(bool increasing, bool strictly_increasing, bool decreasing, + bool strictly_decreasing, Datum* out) { + ARROW_ASSIGN_OR_RAISE( + *out, StructScalar::Make({std::make_shared<BooleanScalar>(increasing), + std::make_shared<BooleanScalar>(strictly_increasing), + std::make_shared<BooleanScalar>(decreasing), + std::make_shared<BooleanScalar>(strictly_decreasing)}, + {"increasing", "strictly_increasing", "decreasing", + "strictly_decreasing"})); + return Status::OK(); +} + +template <typename DataType> +enable_if_floating_point<DataType> IsMonotonicCheck( + const typename DataType::c_type& current, const typename DataType::c_type& next, + bool* increasing, bool* strictly_increasing, bool* decreasing, + bool* strictly_decreasing, const IsMonotonicOptions& options) { + // Short circuit for NaNs. + // https://en.wikipedia.org/wiki/NaN#Comparison_with_NaN + if (std::isnan(current) || std::isnan(next)) { + *increasing = false; + *strictly_increasing = false; + *decreasing = false; + *strictly_decreasing = false; + } else { + bool equal = + // Approximately equal within some error bound (epsilon). + (options.floating_approximate && + (fabs(current - next) <= + static_cast<typename DataType::c_type>(options.epsilon))) || Review comment: There exists support for [floating-point comparisons](https://github.com/apache/arrow/blob/master/cpp/src/arrow/compare.cc#L74-L89), maybe you can reuse this here. Also, this check is not considering sign bit for special cases such as: signed zeros and signed Inf. Ex. `{ -0.0, 0.0 } != { 0.0, -0.0 }`. ########## File path: cpp/src/arrow/compute/api_vector.h ########## @@ -188,6 +188,35 @@ class ARROW_EXPORT PartitionNthOptions : public FunctionOptions { NullPlacement null_placement; }; +/// \brief Options for IsMonotonic +class ARROW_EXPORT IsMonotonicOptions : public FunctionOptions { + public: + enum NullHandling { + /// Ignore nulls. + IGNORE_NULLS, + /// Use min value of element type as the value of nulls. + /// -Inf for floating point numbers. + USE_MIN_VALUE, + /// Use max value of element type as the value of nulls. + /// Inf for floating point numbers. + USE_MAX_VALUE + }; Review comment: [Ordering of nulls and NaNs were also discussed in the sorting function](https://github.com/apache/arrow/pull/11212/files#diff-d8e3089c085273e425a5106e77566f2e1348c483a79eeb544a4c9ee0e8327f34R89-R96). I would expect that `IsMonotonic` and sorting function are consistent. That is, if a sort operation is performed first, then the corresponding `IsMonotonic` should result in true. ########## File path: cpp/src/arrow/compute/kernels/vector_is_monotonic.cc ########## @@ -0,0 +1,321 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "arrow/compute/api_vector.h" +#include "arrow/compute/kernel.h" +#include "arrow/compute/kernels/aggregate_internal.h" +#include "arrow/compute/registry.h" +#include "arrow/util/optional.h" + +namespace arrow { +namespace compute { +namespace internal { + +namespace { +// ---------------------------------------------------------------------- +// IsMonotonic implementation + +using IsMonotonicState = OptionsWrapper<IsMonotonicOptions>; + +Status IsMonotonicOutput(bool increasing, bool strictly_increasing, bool decreasing, + bool strictly_decreasing, Datum* out) { + ARROW_ASSIGN_OR_RAISE( + *out, StructScalar::Make({std::make_shared<BooleanScalar>(increasing), + std::make_shared<BooleanScalar>(strictly_increasing), + std::make_shared<BooleanScalar>(decreasing), + std::make_shared<BooleanScalar>(strictly_decreasing)}, + {"increasing", "strictly_increasing", "decreasing", + "strictly_decreasing"})); + return Status::OK(); +} + +template <typename DataType> +enable_if_floating_point<DataType> IsMonotonicCheck( + const typename DataType::c_type& current, const typename DataType::c_type& next, + bool* increasing, bool* strictly_increasing, bool* decreasing, + bool* strictly_decreasing, const IsMonotonicOptions& options) { + // Short circuit for NaNs. + // https://en.wikipedia.org/wiki/NaN#Comparison_with_NaN + if (std::isnan(current) || std::isnan(next)) { + *increasing = false; + *strictly_increasing = false; + *decreasing = false; + *strictly_decreasing = false; + } else { + bool equal = + // Approximately equal within some error bound (epsilon). + (options.floating_approximate && + (fabs(current - next) <= + static_cast<typename DataType::c_type>(options.epsilon))) || + // Or exactly equal. + current == next; + if (*increasing) { + if (!(equal || next > current)) { + *increasing = false; + *strictly_increasing = false; + } + } + if (*decreasing) { + if (!(equal || next < current)) { + *decreasing = false; + *strictly_decreasing = false; + } + } + if (*strictly_increasing) { + if (equal || !(next > current)) { + *strictly_increasing = false; + } + } + if (*strictly_decreasing) { + if (equal || !(next < current)) { + *strictly_decreasing = false; + } + } + } +} + +template <typename DataType> +enable_if_not_floating_point<DataType> IsMonotonicCheck( + const typename DataType::c_type& current, const typename DataType::c_type& next, + bool* increasing, bool* strictly_increasing, bool* decreasing, + bool* strictly_decreasing, const IsMonotonicOptions& options) { + if (*increasing) { + if (!(next >= current)) { + *increasing = false; + *strictly_increasing = false; + } + } + if (*strictly_increasing) { + if (!(next > current)) { + *strictly_increasing = false; + } + } + if (*decreasing) { + if (!(next <= current)) { + *decreasing = false; + *strictly_decreasing = false; + } + } + if (*strictly_decreasing) { + if (!(next < current)) { + *strictly_decreasing = false; + } + } +} + +template <typename DataType> +enable_if_floating_point<DataType, bool> isnan( + const util::optional<typename DataType::c_type>& opt) { + return opt.has_value() && std::isnan(opt.value()); +} + +template <typename DataType> +enable_if_not_floating_point<DataType, bool> isnan( + const util::optional<typename DataType::c_type>& opt) { + return false; +} + +template <typename DataType> +constexpr enable_if_floating_point<DataType, typename DataType::c_type> min() { + return -std::numeric_limits<typename DataType::c_type>::infinity(); +} + +template <typename DataType> +constexpr enable_if_floating_point<DataType, typename DataType::c_type> max() { + return std::numeric_limits<typename DataType::c_type>::infinity(); +} + +template <typename DataType> +constexpr enable_if_not_floating_point<DataType, typename DataType::c_type> min() { + return std::numeric_limits<typename DataType::c_type>::min(); +} + +template <typename DataType> +constexpr enable_if_not_floating_point<DataType, typename DataType::c_type> max() { + return std::numeric_limits<typename DataType::c_type>::max(); +} + +template <typename DataType> +Status IsMonotonic(KernelContext* ctx, const ExecBatch& batch, Datum* out) { + using ArrayType = typename TypeTraits<DataType>::ArrayType; + using CType = typename TypeTraits<DataType>::CType; + + auto options = IsMonotonicState::Get(ctx); + + // Check batch size + if (batch.values.size() != 1) { + return Status::Invalid("IsMonotonic expects a single datum (array) as input"); + } + + // Safety: + // - Made sure there is at least one input datum. + Datum input = batch[0]; + + // Validate input datum type (useful for direct invocation only). + if (!input.is_array()) { + return Status::Invalid("IsMonotonic expects array datum as input"); + } + + // Safety: + // - Made sure that the input datum is an array. + const std::shared_ptr<ArrayData>& array_data = input.array(); + ArrayType array(array_data); + + // Return early if there are NaNs, zero elements or one element in the array. Review comment: Not sure the NaN comment applies here. ########## File path: cpp/src/arrow/compute/kernels/vector_is_monotonic.cc ########## @@ -0,0 +1,321 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "arrow/compute/api_vector.h" +#include "arrow/compute/kernel.h" +#include "arrow/compute/kernels/aggregate_internal.h" +#include "arrow/compute/registry.h" +#include "arrow/util/optional.h" + +namespace arrow { +namespace compute { +namespace internal { + +namespace { +// ---------------------------------------------------------------------- +// IsMonotonic implementation + +using IsMonotonicState = OptionsWrapper<IsMonotonicOptions>; + +Status IsMonotonicOutput(bool increasing, bool strictly_increasing, bool decreasing, + bool strictly_decreasing, Datum* out) { + ARROW_ASSIGN_OR_RAISE( + *out, StructScalar::Make({std::make_shared<BooleanScalar>(increasing), + std::make_shared<BooleanScalar>(strictly_increasing), + std::make_shared<BooleanScalar>(decreasing), + std::make_shared<BooleanScalar>(strictly_decreasing)}, + {"increasing", "strictly_increasing", "decreasing", + "strictly_decreasing"})); + return Status::OK(); +} + +template <typename DataType> +enable_if_floating_point<DataType> IsMonotonicCheck( + const typename DataType::c_type& current, const typename DataType::c_type& next, + bool* increasing, bool* strictly_increasing, bool* decreasing, + bool* strictly_decreasing, const IsMonotonicOptions& options) { + // Short circuit for NaNs. + // https://en.wikipedia.org/wiki/NaN#Comparison_with_NaN + if (std::isnan(current) || std::isnan(next)) { + *increasing = false; + *strictly_increasing = false; + *decreasing = false; + *strictly_decreasing = false; + } else { + bool equal = + // Approximately equal within some error bound (epsilon). + (options.floating_approximate && + (fabs(current - next) <= + static_cast<typename DataType::c_type>(options.epsilon))) || + // Or exactly equal. + current == next; + if (*increasing) { + if (!(equal || next > current)) { + *increasing = false; + *strictly_increasing = false; + } + } + if (*decreasing) { + if (!(equal || next < current)) { + *decreasing = false; + *strictly_decreasing = false; + } + } + if (*strictly_increasing) { + if (equal || !(next > current)) { + *strictly_increasing = false; + } + } + if (*strictly_decreasing) { + if (equal || !(next < current)) { + *strictly_decreasing = false; + } + } + } +} + +template <typename DataType> +enable_if_not_floating_point<DataType> IsMonotonicCheck( + const typename DataType::c_type& current, const typename DataType::c_type& next, + bool* increasing, bool* strictly_increasing, bool* decreasing, + bool* strictly_decreasing, const IsMonotonicOptions& options) { + if (*increasing) { + if (!(next >= current)) { + *increasing = false; + *strictly_increasing = false; + } + } + if (*strictly_increasing) { + if (!(next > current)) { + *strictly_increasing = false; + } + } + if (*decreasing) { + if (!(next <= current)) { + *decreasing = false; + *strictly_decreasing = false; + } + } + if (*strictly_decreasing) { + if (!(next < current)) { + *strictly_decreasing = false; + } + } +} + +template <typename DataType> +enable_if_floating_point<DataType, bool> isnan( + const util::optional<typename DataType::c_type>& opt) { + return opt.has_value() && std::isnan(opt.value()); +} + +template <typename DataType> +enable_if_not_floating_point<DataType, bool> isnan( + const util::optional<typename DataType::c_type>& opt) { + return false; +} + +template <typename DataType> +constexpr enable_if_floating_point<DataType, typename DataType::c_type> min() { + return -std::numeric_limits<typename DataType::c_type>::infinity(); +} + +template <typename DataType> +constexpr enable_if_floating_point<DataType, typename DataType::c_type> max() { + return std::numeric_limits<typename DataType::c_type>::infinity(); +} + +template <typename DataType> +constexpr enable_if_not_floating_point<DataType, typename DataType::c_type> min() { + return std::numeric_limits<typename DataType::c_type>::min(); +} + +template <typename DataType> +constexpr enable_if_not_floating_point<DataType, typename DataType::c_type> max() { + return std::numeric_limits<typename DataType::c_type>::max(); +} + +template <typename DataType> +Status IsMonotonic(KernelContext* ctx, const ExecBatch& batch, Datum* out) { + using ArrayType = typename TypeTraits<DataType>::ArrayType; + using CType = typename TypeTraits<DataType>::CType; + + auto options = IsMonotonicState::Get(ctx); + + // Check batch size + if (batch.values.size() != 1) { + return Status::Invalid("IsMonotonic expects a single datum (array) as input"); + } + + // Safety: + // - Made sure there is at least one input datum. + Datum input = batch[0]; + + // Validate input datum type (useful for direct invocation only). + if (!input.is_array()) { + return Status::Invalid("IsMonotonic expects array datum as input"); + } + + // Safety: + // - Made sure that the input datum is an array. + const std::shared_ptr<ArrayData>& array_data = input.array(); + ArrayType array(array_data); + + // Return early if there are NaNs, zero elements or one element in the array. + // And return early if there are only nulls. + if (array.length() <= 1 || array.null_count() == array.length()) { + if (std::any_of(array.begin(), array.end(), isnan<DataType>)) { Review comment: Everything in this functions seems general enough to handle most data types, except for `isnan`. Maybe specialize this code block. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
