edponce edited a comment on pull request #11937:
URL: https://github.com/apache/arrow/pull/11937#issuecomment-996249724


   Some general comments:
   * `IsMonotonic` needs to be consistent with corresponding [sorting 
functions](https://arrow.apache.org/docs/cpp/compute.html#sorts-and-partitions),
 such that `IsMonotonic(input) == (Sort(input) == input)`.
   * Currently `IsMonotonic` outputs a struct describing the monotonic 
properties of the data. What are your thoughts on having a convenience wrapper 
function that receives `FunctionOptions` with a single requested monotonic 
behavior? For example, `IsMonotonic(input, 
MonotonicOptions.StrictlyIncreasing)`. This would provide a more readable API 
for client code and bypass the need to unpack the `StructScalar` output to 
check the corresponding monotonic behavior of interest.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to