lidavidm commented on a change in pull request #11964:
URL: https://github.com/apache/arrow/pull/11964#discussion_r771714928
##########
File path: cpp/src/arrow/dataset/file_csv.cc
##########
@@ -171,11 +177,20 @@ static inline
Future<std::shared_ptr<csv::StreamingReader>> OpenReaderAsync(
}));
return reader_fut.Then(
// Adds the filename to the error
- [](const std::shared_ptr<csv::StreamingReader>& reader)
- -> Result<std::shared_ptr<csv::StreamingReader>> { return reader; },
- [source](const Status& err) ->
Result<std::shared_ptr<csv::StreamingReader>> {
- return err.WithMessage("Could not open CSV input source '",
source.path(),
- "': ", err);
+ [=](const std::shared_ptr<csv::StreamingReader>& reader)
+ -> Result<std::shared_ptr<csv::StreamingReader>> {
+#ifdef ARROW_WITH_OPENTELEMETRY
+ span->SetStatus(opentelemetry::trace::StatusCode::kOk);
Review comment:
The default status is actually `Unset`:
https://github.com/open-telemetry/opentelemetry-specification/blob/9216eb8ff1832ae790369e49ce326cb6bc3d1c80/specification/trace/api.md#set-status
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
