jmdeschenes commented on a change in pull request #10565:
URL: https://github.com/apache/arrow/pull/10565#discussion_r773112224
##########
File path: cpp/src/arrow/python/type_traits.h
##########
@@ -334,6 +377,10 @@ static inline int NumPyTypeSize(int npy_type) {
return 4;
case NPY_FLOAT64:
return 8;
+ case NPY_COMPLEX64:
+ return 16;
+ case NPY_COMPLEX128:
+ return 32;
Review comment:
This seems rather strange. Shouldn't it be 8 bytes for `NPY_COMPLEX64`
and 16 bytes for `NPY_COMPLEX128`? They should be exactly twice the values for
NPY_FLOAT32 and NPY_FLOAT64 respectively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
