xudong963 commented on pull request #1471: URL: https://github.com/apache/arrow-datafusion/pull/1471#issuecomment-998840101
The descriptions of our existing tests are clear in the ticket, thanks @alamb. I opened an issue about sqllogictest #1453 the other day. The reason why I opened it is because I think the `SQL / Postgres Integration Tests` isn't solid, it doesn't have a `test scale`. (Indeed Datafusion mainly relies on sql.rs for testing). If I understand correctly, the test refactoring that @hntd187 and @matthewmturner are doing doesn't conflict with what I mentioned above. They mainly want to better classify existing tests, which should be unit tests and which should be integration tests. I think it makes sense to me, thanks @hntd187 @matthewmturner. Now we're used to putting tests directly in sql.rs, but sometimes it's better to put it in a source file with a test mod. Back to my sqllogictest, I think if we can improve the scale of the `SQL / Postgres Integration Tests`, sqllogictest mentioned by me is not necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
