paleolimbot commented on a change in pull request #12011:
URL: https://github.com/apache/arrow/pull/12011#discussion_r773284257
##########
File path: r/R/python.R
##########
@@ -23,11 +23,7 @@ py_to_r.pyarrow.lib.Array <- function(x, ...) {
delete_arrow_array(array_ptr)
})
- x$`_export_to_c`(
- external_pointer_addr_double(array_ptr),
- external_pointer_addr_double(schema_ptr)
- )
-
+ x$`_export_to_c`(array_ptr, schema_ptr)
Review comment:
Should we provide backward compatibility here? I imagine this will error
with `An integer is required` unless a user has an up-to-date pyarrow. I
imagine we should do something like this:
``` r
pa <- reticulate::import("pyarrow")
if (package_version(pa$`__version__`) >= "6.0.0.9000") {
# the new code
} else {
# the old code
}
```
...which I'd be happy to do on a separate JIRA ticket if it's not a good fit
for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
