rok commented on a change in pull request #11818:
URL: https://github.com/apache/arrow/pull/11818#discussion_r773519667
##########
File path: cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc
##########
@@ -452,6 +470,341 @@ struct Nanosecond {
}
};
+// ----------------------------------------------------------------------
+// Round temporal values to given frequency
+
+Result<ValueDescr> ResolveRoundTemporalOutput(KernelContext* ctx,
Review comment:
I was thinking to maybe change unit when rounding. Going to FirstType
for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]