matthewmturner edited a comment on pull request #1074: URL: https://github.com/apache/arrow-rs/pull/1074#issuecomment-1000663951
@alamb to confirm, we arent handling floats with this kernel right? My understanding is our current `T` wouldnt work with that. ive also done some cleaning up - can you let me know if you think this is ok? In particular: 1. It requires the user of the kernel to wrap the array in an `Arc` so that we can use the `as_xx_array` functions 2. I provided two signatures for `dyn_compare_scalar` - one for primitive and one for dictionary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
