alamb commented on pull request #1074: URL: https://github.com/apache/arrow-rs/pull/1074#issuecomment-1002031511
> Sure sounds good. Should I just add those on this PR? I recommend doing the code in multiple PRs to keep the reviews smaller. > actually - are bool values currently supported with DictionaryArray? I think they would be valid per the arrow spec, but I don't think they would be very useful -- A dictionary array of bools will be (much) less efficient both in term of space and CPU than a BooleanArray. This is probably why there is no array builder for them https://docs.rs/arrow/6.4.0/arrow/array/struct.DictionaryArray.html?search=dictionarybuilder I think it is fine to dictionary of bools unimplemented and people can implement them if they want -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
