edponce edited a comment on pull request #12036: URL: https://github.com/apache/arrow/pull/12036#issuecomment-1002223335
I do not suspect it was an "unsafe" constructor, bc the single parameter constructor already performed a check. I think the train of thought was along the lines: _"If Arrow data structures should always be constructed via `XXX::Make()` method which in turn invokes the long-form constructor, then these checks do not need to be repeated in the constructor."_ Since the checks are repeated when going through `XXX::Make()`, then I would argue that the check can be removed from `XXX::Make()` and only left in the constructors. The only issue with this is that when constructors fail, the program is aborted, so an Invalid status cannot be captured/checked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
