lidavidm commented on a change in pull request #11982:
URL: https://github.com/apache/arrow/pull/11982#discussion_r776453828
##########
File path: format/FlightSql.proto
##########
@@ -867,6 +867,45 @@ enum SqlSupportsConvert {
SQL_CONVERT_VARCHAR = 19;
}
+/*
+ * Represents a request to retrieve information about data type supported ona
Flight SQL enabled backend.
+ * Used in the command member of FlightDescriptor for the following RPC calls:
+ * - GetSchema: return the schema of the query.
+ * - GetFlightInfo: execute the catalog metadata request.
+ *
+ * The returned schema will be:
+ * <
+ * type_name: utf8 not null,
+ * data_type: int not null,
+ * column_size: int,
+ * literal_prefix: utf8,
+ * literal_suffix: utf8,
+ * create_params: utf8
+ * nullable: int not null,
+ * case_sensitive: bool null,
+ * searchable: int not null,
+ * unsigned_attribute: bool,
+ * fixed_prec_scale: bool null,
+ * auto_increment: bool,
+ * local_type_name: utf8,
+ * minimum_scale: int,
+ * maximum_scale: int,
+ * sql_data_type: int not null,
+ * sql_datetime_sub: int,
+ * num_prec_radix: int,
+ * interval_precision. int
+ * >
+ * The returned data should be ordered by data_type and then by type_name.
+ */
+message CommandGetTypeInfo {
+ option (experimental) = true;
+
+ /*
+ * Specifies the data type to search for the info.
+ */
+ optional int32 data_type = 1;
Review comment:
Ah okay, so it's entirely up to the client to pass a value compatible
with the given DB? That's a little unfortunate.
##########
File path: format/FlightSql.proto
##########
@@ -867,6 +867,45 @@ enum SqlSupportsConvert {
SQL_CONVERT_VARCHAR = 19;
}
+/*
+ * Represents a request to retrieve information about data type supported ona
Flight SQL enabled backend.
+ * Used in the command member of FlightDescriptor for the following RPC calls:
+ * - GetSchema: return the schema of the query.
+ * - GetFlightInfo: execute the catalog metadata request.
+ *
+ * The returned schema will be:
+ * <
+ * type_name: utf8 not null,
+ * data_type: int not null,
+ * column_size: int,
+ * literal_prefix: utf8,
+ * literal_suffix: utf8,
+ * create_params: utf8
+ * nullable: int not null,
+ * case_sensitive: bool null,
+ * searchable: int not null,
+ * unsigned_attribute: bool,
+ * fixed_prec_scale: bool null,
+ * auto_increment: bool,
+ * local_type_name: utf8,
+ * minimum_scale: int,
+ * maximum_scale: int,
+ * sql_data_type: int not null,
+ * sql_datetime_sub: int,
+ * num_prec_radix: int,
+ * interval_precision. int
+ * >
+ * The returned data should be ordered by data_type and then by type_name.
+ */
+message CommandGetTypeInfo {
+ option (experimental) = true;
+
+ /*
+ * Specifies the data type to search for the info.
+ */
+ optional int32 data_type = 1;
Review comment:
Oh I see, it's also an output column. Makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
