xudong963 commented on a change in pull request #1506:
URL: https://github.com/apache/arrow-datafusion/pull/1506#discussion_r776934499
##########
File path: datafusion/src/logical_plan/expr.rs
##########
@@ -1317,6 +1319,83 @@ pub fn normalize_cols(
.collect()
}
+/// Rewrite sort on aggregate expressions to sort on the column of aggregate
output
+#[inline]
Review comment:
> In Rust, a unit of (separate) compilation is a crate. If a function f
is defined in a crate A, then all calls to f from within A can be inlined, as
the compiler has full access to f. If, however, f is called from some
downstream crate B, such calls can’t be inlined. B has access only to the
signature of f, not its body.
So I think both of them don't need `#[inline]`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
