alamb commented on a change in pull request #1114:
URL: https://github.com/apache/arrow-rs/pull/1114#discussion_r777196071
##########
File path: arrow/src/compute/kernels/comparison.rs
##########
@@ -1116,7 +1116,43 @@ where
dyn_compare_scalar!(&left, right, eq_scalar)
}
_ => Err(ArrowError::ComputeError(
- "Kernel only supports PrimitiveArray or DictionaryArray with
Primitive values".to_string(),
+ "eq_dyn_scalar only supports PrimitiveArray or DictionaryArray
with Primitive values".to_string(),
Review comment:
```suggestion
"lt_dyn_scalar only supports PrimitiveArray or DictionaryArray
with Primitive values".to_string(),
```
##########
File path: arrow/src/compute/kernels/comparison.rs
##########
@@ -1102,7 +1102,7 @@ where
| DataType::UInt32
| DataType::UInt64 => {dyn_compare_scalar!(&left, right, key_type,
eq_scalar)}
_ => Err(ArrowError::ComputeError(
- "Kernel only supports PrimitiveArray or DictionaryArray with
Primitive values".to_string(),
+ "eq_dyn_scalar only supports PrimitiveArray or DictionaryArray
with Primitive values".to_string(),
Review comment:
```suggestion
"lt_dyn_scalar only supports PrimitiveArray or
DictionaryArray with Primitive values".to_string(),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
