westonpace commented on pull request #12031:
URL: https://github.com/apache/arrow/pull/12031#issuecomment-1004306629
I have a test plan which is a hard-coded version of one of the TPC-H queries
and, using this, I think indentation is missing in the GroupByNode's
aggregates. But, this is much better than I was getting before. Also, it
would be nice if we had some info on the hash join node's options, but that
could be left for a follow-up PR as it isn't related to indentation:
```
10:SinkNode{}
9:GroupByNode{keys=["o_orderpriority"], aggregates=[
hash_sum(order_count, {skip_nulls=true, min_count=1}),
]} // <-- This should be indented
8:ProjectNode{projection=["order_count": 1, o_orderpriority]}
7:ProjectNode{projection=[l_orderkey, o_orderpriority]}
6:GroupByNode{keys=["l_orderkey", "o_orderpriority"], aggregates=[
]} // <-- This should be indented
5:ProjectNode{projection=[l_orderkey, o_orderpriority]}
4:HashJoinNode{/* would be nice to have some details here */}
3:ProjectNode{projection=[o_orderkey, o_orderpriority]}
2:SourceNode{}
1:FilterNode{filter=(l_commitdate < l_receiptdate)}
0:SourceNode{}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
