lidavidm commented on a change in pull request #12066:
URL: https://github.com/apache/arrow/pull/12066#discussion_r778084326
##########
File path: cpp/src/arrow/array/util.cc
##########
@@ -511,6 +511,9 @@ class NullArrayFactory {
}
Status Visit(const ExtensionType& type) {
+ std::vector<std::shared_ptr<ArrayData>>
child_data(type.storage_type()->num_fields());
+ out_ =
+ ArrayData::Make(type.storage_type(), length_, {buffer_}, child_data,
length_, 0);
Review comment:
Looks like this causes the Python tests to fail. Should `out_` have the
storage type instead of the extension type? It seems just
`out_->child_data.resize(type.storage_type()->num_fields())` should be enough
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
