tustvold commented on a change in pull request #1130:
URL: https://github.com/apache/arrow-rs/pull/1130#discussion_r778421557
##########
File path: parquet/src/arrow/arrow_array_reader.rs
##########
@@ -398,19 +416,37 @@ impl<'a, C: ArrayConverter + 'a> ArrowArrayReader<'a, C> {
offset,
def_levels_byte_len,
);
+ let value_count = Self::count_def_level_values(
Review comment:
You might be able to do `num_values - num_nulls` here as the DataPageV2
has this information. Unfortunately very few implementations in practice seem
to produce such pages, and tbh I'm not entirely sure if num_nulls is what I
think it is...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
