zeroshade commented on a change in pull request #12009:
URL: https://github.com/apache/arrow/pull/12009#discussion_r779122331
##########
File path: go/arrow/math/Makefile
##########
@@ -37,27 +41,42 @@ INTEL_SOURCES := \
int64_avx2_amd64.s int64_sse4_amd64.s \
uint64_avx2_amd64.s uint64_sse4_amd64.s
+ARM_SOURCES := \
+ float64_neon_arm64.s \
+ int64_neon_arm64.s \
+ uint64_neon_arm64.s
+
.PHONEY: assembly
-assembly: $(INTEL_SOURCES)
+#ifeq ($(GOARCH), arm64)
+assembly: $(ARM_SOURCES)
+#else
+#assembly: $(INTEL_SOURCES)
+#endif
Review comment:
@guyuqi Sounds good to me, can we just document either in a comment or
in the readme the procedure for re-generating the arm64 assembly including a
comment about the fact that c2goasm doesn't support it? I'm happy once there's
a comment or documentation in the readme just so we don't lose this info if we
lose track of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
