wjones127 commented on a change in pull request #11956:
URL: https://github.com/apache/arrow/pull/11956#discussion_r779876232



##########
File path: r/src/symbols.cpp
##########
@@ -75,6 +75,10 @@ SEXP data::classes_arrow_large_list = 
precious(cpp11::writable::strings(
 SEXP data::classes_arrow_fixed_size_list = precious(cpp11::writable::strings(
     {"arrow_fixed_size_list", "vctrs_list_of", "vctrs_vctr", "list"}));
 
+// TODO: do we even need this?
+SEXP data::classes_arrow_map = precious(
+    cpp11::writable::strings({"arrow_map", "arrow_list", "vctrs_list_of", 
"vctrs_vctr", "list"}));
+

Review comment:
       Okay. I think I want to leave that for a follow-up. IMO most of the 
value in implementing map arrays is reading files and streams from other 
languages; I don't think it's as meaningful a type in R.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to