westonpace commented on a change in pull request #11991:
URL: https://github.com/apache/arrow/pull/11991#discussion_r780473351



##########
File path: python/pyarrow/_dataset.pyx
##########
@@ -2239,10 +2233,6 @@ cdef class Scanner(_Weakrefable):
     use_threads : bool, default True
         If enabled, then maximum parallelism will be used determined by
         the number of available CPU cores.
-    use_async : bool, default False

Review comment:
       This was bugging me so I went ahead and played around with it.  I don't 
see any consequences if I change `bint use_async=True` to `object use_async = 
None` and that allows me to emit the deprecation warning on both 
`use_async=True` and `use_async=False` (i.e. emit a warning if the user uses 
the flag in any way).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to