rok commented on a change in pull request #12097:
URL: https://github.com/apache/arrow/pull/12097#discussion_r780237616
##########
File path: r/R/dplyr-funcs-datetime.R
##########
@@ -101,6 +101,10 @@ register_bindings_datetime <- function() {
Expression$create("day_of_week", x, options = list(count_from_zero =
FALSE, week_start = week_start))
})
+ register_binding("week", function(x) {
+ (call_binding("yday", x) - 1) %/% 7 + 1
+ })
+
Review comment:
I think `lubridate::week` should match `WeekOptions::USDefaults()`. [See
here](https://github.com/apache/arrow/blob/master/cpp/src/arrow/compute/api_scalar.h#L421-L425).
If needed we cal always adjust the [week compute
function](https://github.com/apache/arrow/blob/master/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc#L413-L478)
to also match lubridate.
##########
File path: r/R/dplyr-funcs-datetime.R
##########
@@ -101,6 +101,10 @@ register_bindings_datetime <- function() {
Expression$create("day_of_week", x, options = list(count_from_zero =
FALSE, week_start = week_start))
})
+ register_binding("week", function(x) {
+ (call_binding("yday", x) - 1) %/% 7 + 1
+ })
+
Review comment:
I think `lubridate::week` should match `WeekOptions::USDefaults()`. [See
here](https://github.com/apache/arrow/blob/master/cpp/src/arrow/compute/api_scalar.h#L421-L425).
If needed we can always adjust the [week compute
function](https://github.com/apache/arrow/blob/master/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc#L413-L478)
to also match lubridate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
