nealrichardson commented on a change in pull request #11360:
URL: https://github.com/apache/arrow/pull/11360#discussion_r780469400
##########
File path: .github/workflows/r.yml
##########
@@ -324,6 +324,10 @@ jobs:
cd r/tests
sed -i.bak -E -e 's/"arrow"/"arrow", reporter = "location"/'
testthat.R
rm -f testthat.R.bak
+ - name: Build cpp11 (on R 3.6)
+ if: ${{ matrix.rtools == 35 }}
+ shell: Rscript {0}
+ run: install.packages("cpp11", type = "source")
Review comment:
Why does this matter? cpp11 is header-only so the "binary" package isn't
meaningful I didn't think
##########
File path: r/DESCRIPTION
##########
@@ -59,6 +59,7 @@ Suggests:
testthat (>= 3.1.0),
tibble,
withr
+LinkingTo: cpp11 (>= 0.4.2)
Review comment:
This should be the relevant change we need, cf.
https://github.com/apache/arrow/runs/4550863089?check_suite_focus=true#step:16:224
##########
File path: .github/workflows/r.yml
##########
@@ -324,6 +324,10 @@ jobs:
cd r/tests
sed -i.bak -E -e 's/"arrow"/"arrow", reporter = "location"/'
testthat.R
rm -f testthat.R.bak
+ - name: Build cpp11 (on R 3.6)
+ if: ${{ matrix.rtools == 35 }}
+ shell: Rscript {0}
+ run: install.packages("cpp11", type = "source")
Review comment:
I see, we install with `options(pkgType="win.binary")` so that's why on
R 3.6 we weren't getting new enough cpp11.
##########
File path: .github/workflows/r.yml
##########
@@ -324,6 +324,10 @@ jobs:
cd r/tests
sed -i.bak -E -e 's/"arrow"/"arrow", reporter = "location"/'
testthat.R
rm -f testthat.R.bak
+ - name: Build cpp11 (on R 3.6)
Review comment:
```suggestion
- name: Install cpp11 (on R 3.6)
# Since we force installation of binary packages below, dependency
versions
# are frozen for old versions of R. We need newer cpp11 than is
available as
# "binary" (though it doesn't matter because the cpp11 R package is
just a
# vehicle for the header-only C++ code.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
