hntd187 commented on a change in pull request #1541:
URL: https://github.com/apache/arrow-datafusion/pull/1541#discussion_r781661135
##########
File path: datafusion/src/datasource/object_store/mod.rs
##########
@@ -40,18 +41,21 @@ use crate::error::{DataFusionError, Result};
#[async_trait]
pub trait ObjectReader: Send + Sync {
/// Get reader for a part [start, start + length] in the file
asynchronously
- async fn chunk_reader(&self, start: u64, length: usize)
- -> Result<Box<dyn AsyncRead>>;
+ async fn chunk_reader(
+ &self,
+ start: u64,
+ length: usize,
+ ) -> Result<Box<dyn AsyncRead>, Box<dyn Error>>;
Review comment:
Not disagreeing with the overall point of this PR, error mapping is a
pretty laborious task in Rust, I'm just trying to save a second PR when/if the
Send + Sync bites you. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
