alamb commented on a change in pull request #1039:
URL: https://github.com/apache/arrow-rs/pull/1039#discussion_r782240568
##########
File path: arrow/src/array/transform/boolean.rs
##########
@@ -15,12 +15,9 @@
// specific language governing permissions and limitations
// under the License.
+use super::{Extend, _MutableArrayData, utils::resize_for_bits};
use crate::array::ArrayData;
-
-use super::{
- Extend, _MutableArrayData,
- utils::{resize_for_bits, set_bits},
-};
+use crate::util::bit_mask::set_bits;
Review comment:
just to be explicit the `bit_mask` crate is not exposed publically
##########
File path: arrow/src/util/mod.rs
##########
@@ -18,6 +18,7 @@
#[cfg(feature = "test_utils")]
pub mod bench_util;
pub mod bit_chunk_iterator;
+pub(crate) mod bit_mask;
Review comment:
Let's leave it as `pub(crate)` until the next round of parquet finagling
is complete and then make a separate decision (PR) about if we should make it
public or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
