tustvold commented on a change in pull request #1054:
URL: https://github.com/apache/arrow-rs/pull/1054#discussion_r782416996
##########
File path: arrow/src/array/builder.rs
##########
@@ -398,6 +400,117 @@ impl BooleanBufferBuilder {
}
}
+ /// Append `count` bits from `to_set`
+ ///
+ /// `to_set` is a slice of bits packed LSB-first into `[u8]`
+ ///
+ /// # Panics
+ ///
+ /// Panics if `to_set` does not contain `ceil(count / 8)` bytes
+ #[inline]
+ pub fn append_packed(&mut self, count: usize, to_set: &[u8]) {
+ assert_eq!((count + 7) >> 3, to_set.len());
+
+ let new_len = self.len + count;
+ let new_buf_len = (new_len + 7) >> 3;
+ self.buffer.reserve(new_buf_len - self.buffer.len());
+
+ let whole_bytes = count >> 3;
+ let overrun = count & 7;
+
+ let skew = self.len & 7;
+ if skew == 0 {
+ self.buffer.extend_from_slice(&to_set[..whole_bytes]);
Review comment:
I ended up going with a different approach in #1039 that reused some
existing code in arrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
