alamb opened a new pull request #1550: URL: https://github.com/apache/arrow-datafusion/pull/1550
# Which issue does this PR close? Re https://github.com/apache/arrow-datafusion/issues/1549 # Rationale for this change All of this code is unused but that is very unobvious For aggregates, only `update_batch` and `merge_batch` are needed. The extra implementation in terms of `ScalarValue`s is never called. # What changes are included in this PR? 1. Remove the `update` and `merge` operations on Scalars 2. Remove the arithmetic functions `ScalarValue::sum`, `ScalarValue::div` and `ScalarValue::mul` that were added in https://github.com/apache/arrow-datafusion/pull/1525 3. PR removes the other implementations for Aggregates, and I will submit a follow on PR that changes the `Accumulator` trait (but will also be a backwards incompatible PR change so I want to have that discussion separately) # Are there any user-facing changes? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
