zeroshade commented on a change in pull request #11538:
URL: https://github.com/apache/arrow/pull/11538#discussion_r783131136
##########
File path: go/parquet/file/column_writer.go
##########
@@ -179,7 +179,7 @@ func (w *columnWriter) TotalBytesWritten() int64 {
}
func (w *columnWriter) RowsWritten() int {
- return w.rowsWritten
+ return w.rowsWritten + w.numBufferedRows
Review comment:
the documentation is still correct, I had to add that because of the way
I split it up to ensure proper writing of rows vs values in the data pages
themselves. `RowsWritten` is still the number of rows written to the column
(but not necessarily flushed yet).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
