amol- commented on a change in pull request #12076:
URL: https://github.com/apache/arrow/pull/12076#discussion_r783757541
##########
File path: python/pyarrow/_compute.pyx
##########
@@ -1027,6 +1266,15 @@ cdef class _ScalarAggregateOptions(FunctionOptions):
class ScalarAggregateOptions(_ScalarAggregateOptions):
+ __doc__ = f"""
+ Options for scalar aggregations.
+
+ Parameters
+ ----------
+ {_skip_nulls_doc()}
Review comment:
Are we sure there is a strong guarantee that the options of `skip_nulls`
and `min_count` will always forever match with those of `ScalarAggregate`? I
mean, now they match, but I'm concerned that in 6 months we will have forgotten
that the docstrings influence multiple classes and might accidentally add
options that don't exist in the classes that reuse the existing docstrings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
