amol- commented on a change in pull request #12076:
URL: https://github.com/apache/arrow/pull/12076#discussion_r783810077
##########
File path: python/pyarrow/_compute.pyx
##########
@@ -1027,6 +1266,15 @@ cdef class _ScalarAggregateOptions(FunctionOptions):
class ScalarAggregateOptions(_ScalarAggregateOptions):
+ __doc__ = f"""
+ Options for scalar aggregations.
+
+ Parameters
+ ----------
+ {_skip_nulls_doc()}
Review comment:
You are right, the numpydoc check would catch a set of issues. I'm
wondering btw if it's actually running given that it didn't catch
https://github.com/apache/arrow/blob/master/python/pyarrow/array.pxi#L714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
