paleolimbot commented on a change in pull request #12152:
URL: https://github.com/apache/arrow/pull/12152#discussion_r784903844
##########
File path: r/R/util.R
##########
@@ -209,5 +209,5 @@ handle_csv_read_error <- function(e, schema) {
))
}
- abort(e)
+ stop(e)
Review comment:
I think in this case you probably want `abort(conditionMessage(e))`:
``` r
rlang::abort(simpleError("fish"))
#> Error in format_error_bullets(x[-1]): nms %in% c("i", "x", "") is not TRUE
rlang::abort(conditionMessage(simpleError("fish")))
#> Error: fish
```
The `call. = FALSE` thing is hardwired into my head because it's in the
tidyverse style guide (
https://style.tidyverse.org/error-messages.html#problem-statement ), and in
this case it will give an error starting with "Error in
handle_csv_read_error():", which won't make sense to the user since it's an
internal function. In many other cases it doesn't matter and will give useful
debugging information to the user!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
